Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 style changes and node v4. #66

Merged
merged 2 commits into from Nov 4, 2015
Merged

ES6 style changes and node v4. #66

merged 2 commits into from Nov 4, 2015

Conversation

jagoda
Copy link
Contributor

@jagoda jagoda commented Nov 1, 2015

No description provided.

@jagoda jagoda added breaking changes Change that can breaking existing code dependency Update module dependency labels Nov 1, 2015
@jagoda jagoda added this to the 4.0.0 milestone Nov 1, 2015
@@ -1,7 +1,7 @@
language: node_js

node_js:
- "0.10"
- "4.0"
- 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep 4.0 since we want to make sure we support that one specifically in addition to 4 latest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok.

jagoda added a commit that referenced this pull request Nov 4, 2015
ES6 style changes and node v4.
@jagoda jagoda merged commit f818a54 into hapijs:master Nov 4, 2015
@jagoda jagoda deleted the feat-es6 branch November 4, 2015 00:39
@jagoda jagoda self-assigned this Nov 4, 2015
- "4.0"
- "4"
- "5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the "". No need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jagoda added a commit to jagoda/vision that referenced this pull request Nov 4, 2015
jagoda added a commit to jagoda/vision that referenced this pull request Nov 4, 2015
jagoda added a commit to jagoda/vision that referenced this pull request Nov 10, 2015
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants